rollback.yml uses git checkout which does not work for symlink-based PHP deployments #5

New issue

Open

opened 2026-05-26 09:25:52 -06:00 by Xeplosion · 0 comments

Xeplosion commented

2026-05-26 09:25:52 -06:00

Owner

What happened?

rollback.yml rolls back by running git checkout HEAD~1 on the server. This works for repos where the deployed files are a git working directory, but breaks for PHP repos using the symlink-based release strategy — the deployed code lives in a versioned releases/ directory, not a git repo, and current is just a symlink pointing at it.

Steps to reproduce

Deploy a PHP repo using template-php
Trigger rollback.yml either manually or via a failed healthcheck
The rollback step will fail or silently do nothing useful since /var/www/<site>/releases/ is not a git repo

Expected behavior

Rollback flips the current symlink to the previous release directory and reloads php-fpm and nginx, matching the same atomic deploy strategy used by service-start.sh.

Environment

Any repo using template-php with symlink-based deployment

Additional context

Two possible solutions — either add a scripts/rollback.sh stub that rollback.yml calls (consistent with the existing script delegation pattern), or add a deploy.strategy field to xegames.config.yml (git or symlink) and have rollback.yml branch on that value. The scripts/rollback.sh approach is preferred as it keeps workflow logic minimal and puts implementation detail in the script where it belongs. Both rollback.yml in .forgejo and template-php need updating.

Checklist

I have searched for existing issues before opening this one
I can reliably reproduce this
I have included enough detail to investigate

### What happened? `rollback.yml` rolls back by running `git checkout HEAD~1` on the server. This works for repos where the deployed files are a git working directory, but breaks for PHP repos using the symlink-based release strategy — the deployed code lives in a versioned `releases/` directory, not a git repo, and `current` is just a symlink pointing at it. ### Steps to reproduce 1. Deploy a PHP repo using `template-php` 2. Trigger `rollback.yml` either manually or via a failed healthcheck 3. The rollback step will fail or silently do nothing useful since `/var/www/<site>/releases/` is not a git repo ### Expected behavior Rollback flips the `current` symlink to the previous release directory and reloads php-fpm and nginx, matching the same atomic deploy strategy used by `service-start.sh`. ### Environment Any repo using `template-php` with symlink-based deployment ### Additional context Two possible solutions — either add a `scripts/rollback.sh` stub that `rollback.yml` calls (consistent with the existing script delegation pattern), or add a `deploy.strategy` field to `xegames.config.yml` (`git` or `symlink`) and have `rollback.yml` branch on that value. The `scripts/rollback.sh` approach is preferred as it keeps workflow logic minimal and puts implementation detail in the script where it belongs. Both `rollback.yml` in `.forgejo` and `template-php` need updating. ### Checklist - [x] I have searched for existing issues before opening this one - [x] I can reliably reproduce this - [x] I have included enough detail to investigate

Xeplosion added the

labels

2026-05-26 09:25:52 -06:00

Xeplosion added this to the Infrastructure & Devops project

2026-06-15 16:54:21 -06:00